From 1a72ae4fe27a14cf60916f991a2c94da91d9e54a Mon Sep 17 00:00:00 2001
From: Solomon English <stranger@lithe.net>
Date: Wed, 17 Mar 2021 11:05:08 -0700
Subject: [PATCH] fix(typings): update return type from emit (#3843)

```
(channel ? io.to(channel) : io).emit("stuff", message);
```

would no longer compile.

Related: https://github.com/socketio/socket.io/issues/3844
---
 lib/broadcast-operator.ts | 4 ++--
 lib/namespace.ts          | 2 +-
 lib/parent-namespace.ts   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/broadcast-operator.ts b/lib/broadcast-operator.ts
index ca140b98d6..a7a0933c3a 100644
--- a/lib/broadcast-operator.ts
+++ b/lib/broadcast-operator.ts
@@ -133,7 +133,7 @@ export class BroadcastOperator<EmitEvents extends EventsMap>
   public emit<Ev extends EventNames<EmitEvents>>(
     ev: Ev,
     ...args: EventParams<EmitEvents, Ev>
-  ): true {
+  ): boolean {
     if (RESERVED_EVENTS.has(ev)) {
       throw new Error(`"${ev}" is a reserved event name`);
     }
@@ -276,7 +276,7 @@ export class RemoteSocket<EmitEvents extends EventsMap>
   public emit<Ev extends EventNames<EmitEvents>>(
     ev: Ev,
     ...args: EventParams<EmitEvents, Ev>
-  ): true {
+  ): boolean {
     return this.operator.emit(ev, ...args);
   }
 
diff --git a/lib/namespace.ts b/lib/namespace.ts
index 909ec3e2dd..5730a48f01 100644
--- a/lib/namespace.ts
+++ b/lib/namespace.ts
@@ -229,7 +229,7 @@ export class Namespace<
   public emit<Ev extends EventNames<EmitEvents>>(
     ev: Ev,
     ...args: EventParams<EmitEvents, Ev>
-  ): true {
+  ): boolean {
     return new BroadcastOperator<EmitEvents>(this.adapter).emit(ev, ...args);
   }
 
diff --git a/lib/parent-namespace.ts b/lib/parent-namespace.ts
index e7f64188cd..353d9bd812 100644
--- a/lib/parent-namespace.ts
+++ b/lib/parent-namespace.ts
@@ -35,7 +35,7 @@ export class ParentNamespace<
   public emit<Ev extends EventNames<EmitEvents>>(
     ev: Ev,
     ...args: EventParams<EmitEvents, Ev>
-  ): true {
+  ): boolean {
     this.children.forEach((nsp) => {
       nsp.emit(ev, ...args);
     });