New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the per-frame DEFLATE extension #1148

Closed
bendiy opened this Issue Jan 29, 2013 · 38 comments

Comments

Projects
None yet
@bendiy
Copy link

bendiy commented Jan 29, 2013

Any plans to add support for per-frame DEFLATE: http://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06

Some basic tests suggest I could reduce the size of my message frames to just 12% of their original size. That would help a lot with bandwidth usage.

Thanks!

@brianneisler

This comment has been minimized.

Copy link

brianneisler commented Apr 16, 2013

+1, any plans to implement this in the near future?

@zackbloom

This comment has been minimized.

Copy link

zackbloom commented Aug 8, 2013

👍

2 similar comments
@abdielou

This comment has been minimized.

Copy link

abdielou commented Aug 23, 2013

+1

@Zolmeister

This comment has been minimized.

Copy link

Zolmeister commented Sep 8, 2013

+1

@vincentwoo

This comment has been minimized.

Copy link

vincentwoo commented Sep 12, 2013

👍 🍔 👍

@tjwebb

This comment has been minimized.

Copy link

tjwebb commented Sep 25, 2013

+1

4 similar comments
@marcucio

This comment has been minimized.

Copy link

marcucio commented Sep 30, 2013

+1

@poscar

This comment has been minimized.

Copy link

poscar commented Sep 30, 2013

+1

@PascalPflaum

This comment has been minimized.

Copy link

PascalPflaum commented Sep 30, 2013

+1

@BenDavidJamin

This comment has been minimized.

Copy link

BenDavidJamin commented Nov 11, 2013

👍

@gtamas

This comment has been minimized.

Copy link

gtamas commented Nov 24, 2013

Are you working on this? If so, when will this be available?

@jnorris441

This comment has been minimized.

Copy link

jnorris441 commented Feb 26, 2014

My app sends a lot of data, this would help quite a bit....

@arendjr

This comment has been minimized.

Copy link

arendjr commented Mar 6, 2014

Maybe needless to say, but please make this functionality opt-in on the server-side.

I notice Chrome currently sends this header: "Sec-WebSocket-Extensions:permessage-deflate; client_max_window_bits, x-webkit-deflate-frame", and I wondered what the impact would be. But I actually send many small frames over Socket.io, and applying gzip on them manually actually inflates their size. So if this were implemented, I would rather have the option to turn it off server-side completely.

@enusbaum

This comment has been minimized.

Copy link

enusbaum commented Apr 28, 2014

+1

@bikegriffith

This comment has been minimized.

Copy link

bikegriffith commented Jun 2, 2014

Bump. Would love this. Have a massive record structure we want to efficiently send to the client over our WebSocket connection (~10MB).

@aartiles

This comment has been minimized.

Copy link

aartiles commented Jun 19, 2014

+1

1 similar comment
@khuongduybui

This comment has been minimized.

Copy link

khuongduybui commented Jun 27, 2014

+1

@jnorris441

This comment has been minimized.

Copy link

jnorris441 commented Aug 15, 2014

I am starting to send too much data. Ugh, I don't want to go back to gzipped REST

@rauchg

This comment has been minimized.

Copy link
Contributor

rauchg commented Aug 15, 2014

We're gonna support this for sure. 1.1 is out in a couple days, and this should be in 1.2

@rauchg

This comment has been minimized.

Copy link
Contributor

rauchg commented Sep 4, 2014

Closed by mistake.

@rauchg rauchg reopened this Sep 4, 2014

@AkramKamal

This comment has been minimized.

Copy link

AkramKamal commented Sep 15, 2014

+1

2 similar comments
@branimir93

This comment has been minimized.

Copy link

branimir93 commented Sep 23, 2014

+1

@morus12

This comment has been minimized.

Copy link

morus12 commented Oct 13, 2014

+1

@rauchg

This comment has been minimized.

Copy link
Contributor

rauchg commented Oct 13, 2014

We're actively working on this, my +1ing friends.

@rase- rase- added this to the 1.2.0 milestone Oct 13, 2014

@rase- rase- added the In Progress label Oct 13, 2014

@bendiy

This comment has been minimized.

Copy link
Author

bendiy commented Oct 14, 2014

Great news. Thanks for the update. I look forward to turning my +1 bot off ;)

@morus12

This comment has been minimized.

Copy link

morus12 commented Oct 16, 2014

I've created simple deflate extension (forked from socket.io 0.9.14) for an internal use, please feel free if you would like to use it.

https://github.com/livechat/socket.io/tree/0.10.0

Can't wait for official support ;)

@syzer

This comment has been minimized.

Copy link

syzer commented Oct 17, 2014

+1

1 similar comment
@edoardofenati

This comment has been minimized.

Copy link

edoardofenati commented Nov 7, 2014

+1

@rauchg

This comment has been minimized.

Copy link
Contributor

rauchg commented Nov 15, 2014

We're working on this. Part of the challenge is that ws doesn't have support for it yet, but we're addressing it.

@rauchg rauchg closed this Nov 25, 2014

@nkzawa

This comment has been minimized.

Copy link
Contributor

nkzawa commented Nov 25, 2014

@guille Did you intentionally close this issue?

@rauchg rauchg reopened this Nov 25, 2014

@rauchg

This comment has been minimized.

Copy link
Contributor

rauchg commented Nov 25, 2014

Mistake by rauchgbot

@leearmstrong

This comment has been minimized.

Copy link

leearmstrong commented Dec 24, 2014

+1

@rustinlee

This comment has been minimized.

Copy link

rustinlee commented Jan 2, 2015

Not that there's even a point to +1ing any more, but here you go anyway 👍

@nhitchins

This comment has been minimized.

Copy link

nhitchins commented Jan 14, 2015

+10000000

@rauchg

This comment has been minimized.

Copy link
Contributor

rauchg commented Jan 15, 2015

Support for engine.io is almost ready. Sit tight!

On Wed Jan 14 2015 at 5:57:26 PM nhitchins notifications@github.com wrote:

+10000000


Reply to this email directly or view it on GitHub
#1148 (comment)
.

@nhitchins

This comment has been minimized.

Copy link

nhitchins commented Jan 15, 2015

awesome!

@leearmstrong

This comment has been minimized.

Copy link

leearmstrong commented Jan 22, 2015

I see this has made it to the engine.io-client overnight, is there a way to try Socket.IO with this at all? Would it be a case of forking and editing the package.json?

@rauchg

This comment has been minimized.

Copy link
Contributor

rauchg commented Jan 22, 2015

Continuing this here:
#1947

We're about to merge the socket.io integration. At that point you can use it :)

@rauchg rauchg closed this Jan 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment