Not git checkin friendly #1607

Closed
rauchg opened this Issue Jun 9, 2014 · 4 comments

Projects

None yet

3 participants

@rauchg
Contributor
rauchg commented Jun 9, 2014
   ∴ socket.io (master) find . -name '.gitignore'
./.gitignore
./node_modules/socket.io-adapter/node_modules/socket.io-parser/node_modules/emitter/.gitignore
./node_modules/socket.io-client/node_modules/bind/.gitignore
./node_modules/socket.io-client/node_modules/emitter/.gitignore
./node_modules/socket.io-client/node_modules/engine.io-client/node_modules/has-cors/node_modules/global/.gitignore
./node_modules/socket.io-parser/node_modules/emitter/.gitignore
   ∴ socket.io (master) cat ./node_modules/socket.io-client/node_modules/emitter/.gitignore
node_modules
   ∴ socket.io (master) cat ./node_modules/socket.io-client/node_modules/engine.io-client/node_modules/has-cors/node_modules/global/.gitignore
/components
/build
/node_modules
   ∴ socket.io (master) cat ./node_modules/socket.io-client/node_modules/bind/.gitignore
node_modules

We have to get rid of those dependencies with bad .gitignores.

@evanlucas

+15000. This messed me up for a few hours before I figured out what was going on.

@3rd-Eden
Contributor

Why not npmignore the .gitignore?

@rauchg rauchg closed this in fbd36b6 Jul 15, 2014
@rauchg
Contributor
rauchg commented Jul 15, 2014

Done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment