New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is thrown out when Nodejs ups to 10.x #3319

Open
Maledong opened this Issue Aug 28, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@Maledong
Copy link

Maledong commented Aug 28, 2018

  • report a bug
  • request a feature

Current behaviour

For Nodejs 8.x and 9.x (with uws = 8.x) works properly.

For Nodejs 10.x + uws (>= 8.x <= 9.x): it throws an error saying "Error: Compilation of µWebSockets has failed and there is no pre-compiled binary available for your system. Please install a supported C++11 compiler and reinstall the module 'uws'".

For Nodejs 10.x + uws (>=10.x):cannot find module 'uws'.

Steps to reproduce (if the current behaviour is a bug)

Just assign 'uws' to wsEngine, each time I'll remove all the imports by directly removing node_modules and install them by running npm i. Then my uws is installed in the mode of dev-dependencies.

Expected behaviour

Works properly like Node 8 or 9.

Setup

  • OS: Windows 8.1 (SP1), Linux (x64
  • browser: N/A
  • socket.io version: 2.0.4

Other Info

I found uws is deprecated now, so in the main page of Socket.IO SHOULD'T SUPPORT THAT any more (See https://socket.io/docs/server-api/ part). And maybe there's something code to be changed with, or change to a new lib something like uws.

See the DUPLICATED uws: https://www.npmjs.com/package/uws, the version is changing TOO RAPIDLY, not so stable.

@Andrews54757

This comment has been minimized.

Copy link

Andrews54757 commented Sep 14, 2018

@Maledong UWS has been deprecated because the owner wanted to make a hefty personal statement. There is nothing wrong with the code, but he has decided to go out of his way to publish an EMPTY package just to break about everything on the internet. What a f**ing do*chebag.

https://www.reddit.com/r/node/comments/91kgte/uws_has_been_deprecated/

@Maledong

This comment has been minimized.

Copy link

Maledong commented Sep 14, 2018

@Andrews54757:I see, however I'm not sure whether you've noticed that since Nodejs 10.x, the uws cannot be used and there'll be runtime error... This is a serious problem, and we have to use Node v8, 9, if we wanna keep this uws or when the author fixed that.... Try to think what will we do if we're running on Nodejs 10.x or later versions in the future according to this senario?! And this is just what I'm worrying about, so hope you understand.

I don't mean the BUG is created in your own project but just because of this f**ing reason. Maybe we have to work around this problem by removing this or doing something trick to cope with that.

What's more, the version is changing too rapidly, which looks unstable:(

What a f**ing do*chebag.

Ah ha haha……

@Andrews54757

This comment has been minimized.

Copy link

Andrews54757 commented Sep 15, 2018

@Maledong Hmm, UWS with NodeJS 10.x does not work? I am using nodejs 10.10.0 and UWS is working fine.

Make sure to use the last UWS release that works (Not an empty package): 10.148.1

I had that error too. Fixed by switching UWS from latest to that version. Seems like the package owner intentionally broke stuff (He put an empty package), so of course you get the uws not found error.

That is why he is a f**ing do*chebag. Not only did he deprecate it, but he put an EMPTY package as latest on the NPM registry. That means that installs with latest will not work as he intentionally broke it.

The empty package he published is version 10.148.2/99.0.0. Here are the files: uws.zip

Only the readme file, and the package.json file. That is it.

According to the user, this is why (Not making url to prevent linking back here):

https://github.com/uNetworking/uWebSockets-node/issues/1

@Maledong

This comment has been minimized.

Copy link

Maledong commented Sep 15, 2018

This is the problem I've been meeting with, I'm not sure whether you've seen this for uws is 10.148.1?
Removed node_modules and run npm i, still occurs :(

image

Nodejs:8.12.0,10.10.0(Windows 8.1 sp1, x86)

8.14.1:It works well with me in Node 8.x and 9.x :)

@Maledong

This comment has been minimized.

Copy link

Maledong commented Sep 15, 2018

In my test, it seems ONLY 10.148.0 works on me without any other configs, leave it here for others if they need help :)

Thank you for your help again @Andrews54757 , It's YOU that have minded and tipped me to have a try of different kinds of versions!

Maledong added a commit to Maledong/egg-socket.io that referenced this issue Sep 15, 2018

lib: Update the whole project to node 8,10
1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.1. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead.

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).

Maledong added a commit to Maledong/egg-socket.io that referenced this issue Sep 15, 2018

lib: Update the whole project to node 8,10
1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.1. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead (Solution from
facebook/react-native#17410).

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).

Maledong added a commit to Maledong/egg-socket.io that referenced this issue Sep 15, 2018

fix (uws): Update this to a fixed version and whole project to Node 8,10
1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.1. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead (Solution from
facebook/react-native#17410).

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).

Maledong added a commit to Maledong/egg-socket.io that referenced this issue Sep 15, 2018

fix (uws): Update this to a fixed version and whole project to Node 8,10
1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.1. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead (Solution from
facebook/react-native#17410).

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).

Maledong added a commit to Maledong/egg-socket.io that referenced this issue Sep 15, 2018

fix (uws): Update this to a fixed version and whole project to Node 8,10
1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.1. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead (Solution from
facebook/react-native#17410).

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).

Maledong added a commit to Maledong/egg-socket.io that referenced this issue Sep 15, 2018

fix (uws): Update this to a fixed version and whole project to Node 8,10
1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.1. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead (Solution from
facebook/react-native#17410).

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).

Maledong added a commit to Maledong/egg-socket.io that referenced this issue Sep 15, 2018

fix (uws): Update this to a fixed version and whole project to Node 8,10
1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.2. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead (Solution from
facebook/react-native#17410).

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).

ngot added a commit to eggjs/egg-socket.io that referenced this issue Sep 20, 2018

fix (uws): Update this to a fixed version and whole project to Node 8…
…,10 (#47)

1) 'uws', due to some personal issues
(See: socketio/socket.io#3319), the author
has destroyed it since 10.148.2. And after several times of trying. Only
10.148.0 can work very very properly in both Nodejs 8.x and 10.x. So use
this instead (Solution from
facebook/react-native#17410).

2) Remove "please find another reliable library instead" in the
corresponding docs because we HAVE TO use 'uws', which is in the
engine.io library, it will check whether you are referring this lib or
not. If not, an error will be thrown out to you.
See:
https://github.com/socketio/engine.io/blob/6a16ea119280a02029618544d44eb515f7f2d076/lib/server.js#L107.

3) Upgrade the whole project to the latest version (Node 8, 10).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment