Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better public .connected property #41

Closed
rauchg opened this issue Aug 30, 2010 · 1 comment
Closed

Better public .connected property #41

rauchg opened this issue Aug 30, 2010 · 1 comment

Comments

@rauchg
Copy link
Contributor

rauchg commented Aug 30, 2010

Right now .connected doesn't indicate if the connection is considered disconnected, but rather if there's an open request for a client. If the client is in a a long-polling disconnection, .connected will be false even though the "socket" is still considered connected.

finalized should be removed, connected should be named open or similar (or maybe use a readyState property with number codes), and an actual connected with the expected behavior should be introduced.

@rauchg
Copy link
Contributor Author

rauchg commented Sep 5, 2010

.connected renamed to ._open, and adopted proper connected (closed by d041572)
example/client updated to latest socket.io client

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant