Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

hiredis requirement causes build issues on Windows #978

Closed
lperrin opened this Issue Aug 5, 2012 · 3 comments

Comments

Projects
None yet
3 participants

lperrin commented Aug 5, 2012

the build script of hiredis requires GNU make, which is rarely present on Windows systems.

I understand that redis is a supported storage engine by socket.io, but it doesn't seem like a core feature to me and having it as a mandatory requirement seems a bit abusive to me.

Is it possible to remove the requirement from package.json and instead print a warning if the user tries to use redis storage without hiredis installed ?

I can write a patch if needed.

Contributor

rauchg commented Aug 6, 2012

Seems like a bug in the redis package, as hiredis shouldn't be mandatory.

It seems to work regardless of npm making warnings(redisstore on windows).

lperrin commented Sep 3, 2012

It seems that it's indeed not a problem with socket.io, closing the issue.

@lperrin lperrin closed this Sep 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment