Update the chat example #2675

Merged
merged 3 commits into from Nov 18, 2016

Projects

None yet

3 participants

@darrachequesne
Contributor
  • make the example autonomous (npm install && npm start)
  • add disconnect/reconnect logs (and send username on reconnection)
@MaffooBristol

Why make it autonomous? Is it to make compilation easier for beginner devs or some other reason?

Deffo a 👍 for the extra events though 😄

@darrachequesne
Contributor

@MaffooBristol yes, it feels easier to run it as a standalone (to me). It may be a bit superfluous though.

@MaffooBristol

Hmm, maybe. But then is it not better for the examples to be entirely tied to the current source version rather than npm's version? Also it means that anyone editing the source can see whether it breaks the chat example, as a form of testing? Just not sure if I think it's the best idea personally.

@bananaappletw

maybe in package.json
It's better to change start command to node index.js to specify file name.
The remaining parts are good!!!

@darrachequesne darrachequesne merged commit a483658 into socketio:master Nov 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@darrachequesne darrachequesne added this to the 1.6.0 milestone Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment