New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client IP instead of server IP for connectionAddress. #328

Merged
merged 1 commit into from Jul 2, 2011

Conversation

Projects
None yet
2 participants
@Irrelon
Contributor

Irrelon commented Jul 2, 2011

Updated Manager.prototype.handshakeData to provide connection.remoteAddress instead of .address() because .address() was returning server IP and .remoteAddress returns client IP.

Updated Manager.prototype.handshakeData to provide connection.remoteA…
…ddress instead of .address() because .address() was returning server IP and .remoteAddress returns client IP.
@rauchg

This comment has been minimized.

Show comment
Hide comment
@rauchg

rauchg Jul 2, 2011

Contributor

Thanks. Sorry for the lame.

Contributor

rauchg commented Jul 2, 2011

Thanks. Sorry for the lame.

@rauchg rauchg closed this Jul 2, 2011

@rauchg rauchg reopened this Jul 2, 2011

rauchg added a commit that referenced this pull request Jul 2, 2011

Merge pull request #328 from coolbloke1324/master
Client IP instead of server IP for connectionAddress.

@rauchg rauchg merged commit c18aa40 into socketio:master Jul 2, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment