Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name field to server cookie option type #4099

Closed
wants to merge 1 commit into from
Closed

Conversation

@douira
Copy link
Contributor

@douira douira commented Sep 16, 2021

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

Using the name field in the cookie server option produces a type error since the field isn't in CookieSerializeOptions but is added by socket.io (engine.io specifically).

New behavior

The type error doesn't happen anymore.

Other information (e.g. related issues)

See the code that references name in engine.io.

@douira douira changed the title Add name field to server cookie option Add name field to server cookie option type Sep 16, 2021
@darrachequesne
Copy link
Member

@darrachequesne darrachequesne commented Sep 20, 2021

Merged as 033c5d3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants