Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding pluggable ID generation see #497 #858

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

martinthomson commented Apr 26, 2012

I want control over session IDs (see #497), but I don't need to give that control to the client. This enables both options.

In my example, I am embedding application state in the session ID so that I can forward messages to back end processing without maintaining additional mappings.

I've also added the ability to get the handshake data through to the ID generator and for the authorize method to add to or override the handshake data. This was obviously intended originally, but never quite connected up (repeated use of ``newData || handshakeData''). This handshake data can be seen by the ID generator as well in order to advise in its processing.

A few more tests added to cover these capabilities.

Contributor

rauchg commented Apr 26, 2012

It doesn't apply cleanly

Contributor

martinthomson commented May 16, 2012

My sincerest apologies for the apply failure. Put that down to me being a complete git (novice). I've managed to bludgeon git into submission and (pending unmerged changes) this should apply cleanly now.

englercj commented Oct 1, 2012

Is this something that will be integrated soonish? Definitely something that would help reduce the additional mappings I have to maintain.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment