Skip to content

Conversation

@andreas
Copy link
Contributor

@andreas andreas commented Nov 5, 2018

These changes make async-http-faraday compatible with async-http v0.36.2, which is required by falcon. I'm not sure they are the best fixes, but it works for me locally.

@coveralls
Copy link

coveralls commented Nov 5, 2018

Pull Request Test Coverage Report for Build 7

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+9.09%) to 100.0%

Files with Coverage Reduction New Missed Lines %
lib/async/http/faraday/adapter.rb 1 45.83%
Totals Coverage Status
Change from base Build 2: 9.09%
Covered Lines: 13
Relevant Lines: 13

💛 - Coveralls

@ioquatix
Copy link
Member

ioquatix commented Nov 5, 2018

Thanks! Do you mind checking why specs are failing? Otherwise I will take a look later today.

@andreas andreas force-pushed the async-http-0.36.2-compat branch from 2e1a28e to 1c79056 Compare November 6, 2018 09:09
@andreas andreas force-pushed the async-http-0.36.2-compat branch from 1c79056 to ea697cc Compare November 6, 2018 09:55
@ioquatix ioquatix merged commit abdcbd6 into socketry:master Nov 6, 2018
@ioquatix
Copy link
Member

ioquatix commented Nov 6, 2018

Great work! Thanks so much.

@ioquatix
Copy link
Member

ioquatix commented Nov 6, 2018

Released v0.2.0 :)

@andreas andreas deleted the async-http-0.36.2-compat branch November 6, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants