Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix purge_cache by specifying a path instead of a path parameter #46

Merged
merged 2 commits into from Mar 20, 2019

Conversation

@knu
Copy link
Contributor

@knu knu commented Feb 28, 2019

Zone#purge_cache is broken in that it posts to the wrong endpoint zones/:id?path=purge_cache instead of zones/:id/purge_cache. Representation#with does not take a path argument, which could be the root of the problem.

@ioquatix
Copy link
Member

@ioquatix ioquatix commented Feb 28, 2019

Thanks. I will review it when I have time.

Loading

@ioquatix ioquatix self-requested a review Feb 28, 2019
@ioquatix ioquatix self-assigned this Feb 28, 2019
@ioquatix ioquatix added the bug label Feb 28, 2019
@knu
Copy link
Contributor Author

@knu knu commented Mar 14, 2019

I've added a call of post and the method should now perform properly. 😅

Loading

@ioquatix
Copy link
Member

@ioquatix ioquatix commented Mar 14, 2019

I'm pulling the branch locally so CI can run.

Loading

@ioquatix
Copy link
Member

@ioquatix ioquatix commented Mar 14, 2019

Is there any kind of test?

Loading

@ioquatix ioquatix merged commit e66ac65 into socketry:master Mar 20, 2019
2 of 3 checks passed
Loading
@ioquatix
Copy link
Member

@ioquatix ioquatix commented Mar 20, 2019

Thanks, this is merged.

Loading

@knu knu deleted the fix_purge_cache branch Mar 23, 2019
@knu knu restored the fix_purge_cache branch Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants