Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix purge_cache by specifying a path instead of a `path` parameter #46

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@knu
Copy link
Contributor

knu commented Feb 28, 2019

Zone#purge_cache is broken in that it posts to the wrong endpoint zones/:id?path=purge_cache instead of zones/:id/purge_cache. Representation#with does not take a path argument, which could be the root of the problem.

@ioquatix

This comment has been minimized.

Copy link
Member

ioquatix commented Feb 28, 2019

Thanks. I will review it when I have time.

@ioquatix ioquatix self-requested a review Feb 28, 2019

@ioquatix ioquatix self-assigned this Feb 28, 2019

@ioquatix ioquatix added the bug label Feb 28, 2019

@knu

This comment has been minimized.

Copy link
Contributor Author

knu commented Mar 14, 2019

I've added a call of post and the method should now perform properly. 😅

@ioquatix

This comment has been minimized.

Copy link
Member

ioquatix commented Mar 14, 2019

I'm pulling the branch locally so CI can run.

@ioquatix

This comment has been minimized.

Copy link
Member

ioquatix commented Mar 14, 2019

Is there any kind of test?

@ioquatix ioquatix merged commit e66ac65 into socketry:master Mar 20, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on knu-fix_purge_cache at 63.095%
Details
@ioquatix

This comment has been minimized.

Copy link
Member

ioquatix commented Mar 20, 2019

Thanks, this is merged.

@knu knu deleted the knu:fix_purge_cache branch Mar 23, 2019

@knu knu restored the knu:fix_purge_cache branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.