Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UploadIO doesn't work for StringIOs in Ruby 1.9.2 #8

Open
arsduo opened this issue May 12, 2011 · 3 comments
Open

UploadIO doesn't work for StringIOs in Ruby 1.9.2 #8

arsduo opened this issue May 12, 2011 · 3 comments
Milestone

Comments

@arsduo
Copy link
Contributor

arsduo commented May 12, 2011

In Ruby 1.8.7, StringIO responds to path, but in 1.9.2, it no longer does, which causes UploadIO to break (composite_io.rb:69).

An easy solution would be to check for obj.respond_to? :path ? obj.path : "no local path" (in my tests, supplying a dummy local path seems to work), but I don't know if that causes problems down the line. If not, one of us could write a pull request.

Thanks for the great gem!

Alex

@nicksieger
Copy link
Contributor

Feel free to send a pull request with that change, I'll merge it right away. Thanks for reporting the issue.

@ioquatix ioquatix added this to the 3.0 milestone May 2, 2017
@ioquatix
Copy link
Member

ioquatix commented May 2, 2017

With the 3.0 release, we will drop support for any ruby < 2.0 so this may no longer be an issue. Do you mind providing a failing test case so we can see if this behaviour still exists?

@tnir
Copy link
Contributor

tnir commented Jun 6, 2022

See #92 for discussion bout supported Ruby versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants