From c9202d82c3445002c3616105af24cfad3d1ba85a Mon Sep 17 00:00:00 2001 From: Tony Arcieri Date: Tue, 14 Nov 2017 10:48:26 -0800 Subject: [PATCH] spec: Use 127.0.0.1 instead of localhost (fixes #172) --- spec/nio/acceptables_spec.rb | 6 +++--- spec/nio/bytebuffer_spec.rb | 2 +- spec/nio/monitor_spec.rb | 2 +- spec/nio/selectables/ssl_socket_spec.rb | 4 ++-- spec/nio/selectables/udp_socket_spec.rb | 8 ++++---- spec/spec_helper.rb | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/spec/nio/acceptables_spec.rb b/spec/nio/acceptables_spec.rb index da11eee..80c93b2 100644 --- a/spec/nio/acceptables_spec.rb +++ b/spec/nio/acceptables_spec.rb @@ -20,13 +20,13 @@ let(:port) { next_available_tcp_port } let :acceptable_subject do - server = TCPServer.new("localhost", port) - TCPSocket.open("localhost", port) + server = TCPServer.new("127.0.0.1", port) + TCPSocket.open("127.0.0.1", port) server end let :unacceptable_subject do - TCPServer.new("localhost", port + 1) + TCPServer.new("127.0.0.1", port + 1) end it_behaves_like "an NIO acceptable" diff --git a/spec/nio/bytebuffer_spec.rb b/spec/nio/bytebuffer_spec.rb index c2987fc..a5cca44 100644 --- a/spec/nio/bytebuffer_spec.rb +++ b/spec/nio/bytebuffer_spec.rb @@ -281,7 +281,7 @@ end context "I/O" do - let(:addr) { "localhost" } + let(:addr) { "127.0.0.1" } let(:port) { next_available_tcp_port } let(:server) { TCPServer.new(addr, port) } let(:client) { TCPSocket.new(addr, port) } diff --git a/spec/nio/monitor_spec.rb b/spec/nio/monitor_spec.rb index 2898b27..e0737af 100644 --- a/spec/nio/monitor_spec.rb +++ b/spec/nio/monitor_spec.rb @@ -4,7 +4,7 @@ require "socket" RSpec.describe NIO::Monitor do - let(:addr) { "localhost" } + let(:addr) { "127.0.0.1" } let(:port) { next_available_tcp_port } let(:reader) { TCPServer.new(addr, port) } diff --git a/spec/nio/selectables/ssl_socket_spec.rb b/spec/nio/selectables/ssl_socket_spec.rb index a7457e8..bda7eaf 100644 --- a/spec/nio/selectables/ssl_socket_spec.rb +++ b/spec/nio/selectables/ssl_socket_spec.rb @@ -4,13 +4,13 @@ require "openssl" RSpec.describe OpenSSL::SSL::SSLSocket do - let(:addr) { "localhost" } + let(:addr) { "127.0.0.1" } let(:port) { next_available_tcp_port } let(:ssl_key) { OpenSSL::PKey::RSA.new(1024) } let(:ssl_cert) do - name = OpenSSL::X509::Name.new([%w(CN localhost)]) + name = OpenSSL::X509::Name.new([%w(CN 127.0.0.1)]) OpenSSL::X509::Certificate.new.tap do |cert| cert.version = 2 cert.serial = 1 diff --git a/spec/nio/selectables/udp_socket_spec.rb b/spec/nio/selectables/udp_socket_spec.rb index 5421ce4..bf41bf4 100644 --- a/spec/nio/selectables/udp_socket_spec.rb +++ b/spec/nio/selectables/udp_socket_spec.rb @@ -7,23 +7,23 @@ let :readable_subject do sock = UDPSocket.new - sock.bind("localhost", udp_port) + sock.bind("127.0.0.1", udp_port) peer = UDPSocket.new - peer.send("hi there", 0, "localhost", udp_port) + peer.send("hi there", 0, "127.0.0.1", udp_port) sock end let :unreadable_subject do sock = UDPSocket.new - sock.bind("localhost", udp_port + 1) + sock.bind("127.0.0.1", udp_port + 1) sock end let :writable_subject do peer = UDPSocket.new - peer.connect "localhost", udp_port + peer.connect "127.0.0.1", udp_port cntr = 0 begin peer.send("X" * 1024, 0) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 0c5aa41..3fea6a8 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -20,7 +20,7 @@ def next_available_tcp_port $current_tcp_port += 1 begin - sock = Timeout.timeout(0.5) { TCPSocket.new("localhost", $current_tcp_port) } + sock = Timeout.timeout(0.5) { TCPSocket.new("127.0.0.1", $current_tcp_port) } rescue Errno::ECONNREFUSED, Timeout::Error break $current_tcp_port end