Improve generated app to support being launched by child_process.fork #316

Closed
wants to merge 1 commit into
from

2 participants

@rngadam

create a new generate + run test;
minimal without extra deps by excluding Stylus and Hogan;
change generated app uses dynamic port alloc;
make generated app importable/forkable;
add parent notification of allocated port;
when not minimal, set stylus+hogan+jade to run demo.

...need some more work, but wanted to get some feedback before going further.

When trying to generate the demo (non-minimal), the page comes up but the browser spits out some errors on the console:

PPB_Graphics2D.PaintImageData: Rectangle is outside bounds.
Uncaught TypeError: Cannot call method 'render' of undefined app.js:10
(anonymous function) app.js:10
EventEmitter.emit system:573
(anonymous function) system:934
EventEmitter.emit system:576
(anonymous function) system:1004
c.emit system:347
c.onPacket system:347
d.onPacket system:347
c.onPacket system:347
c.onData system:347
websocket.onmessage
@rngadam rngadam create a new generate + run test;
minimal without extra deps by excluding Stylus and Hogan;
change generated app uses dynamic port alloc;
make generated app importable/forkable;
add parent notification of allocated port;
when not minimal, set stylus+hogan+jade to run demo.
7810c95
@owenb

Hey. I like where you're going with this. Not had chance to check it out, but will do before I merge it in as it's a big change to a critical function which must work correctly on each branch otherwise users will abandon SocketStream before having chance to try it out.

@rngadam

Absolutely, I don't expect this to be merged immediately. Just wanted to check if if in the direction you want and try to figure out what I missed. Feel free to review line by line and tell me what I should improve.

@owenb

Hi @rngadam

I'm going to close this now as I only want to make minimal changes to 0.3 from this point on. However, there are a lot of good ideas here, some of which I will carry through to 0.4 (which I'm now able to resume working on full time).

@owenb owenb closed this Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment