Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status property on CloseEvent should be called code #14

Closed
majek opened this issue Oct 12, 2011 · 1 comment
Closed

status property on CloseEvent should be called code #14

majek opened this issue Oct 12, 2011 · 1 comment
Assignees
@majek
Milestone
v0.1

Comments

@majek
Copy link
Member

majek commented Oct 12, 2011

I got that wrong. See sockjs-node bug. Spec clearly says:

Create an event that uses the CloseEvent interface, with the event name close, [...] whose wasClean attribute is initialized to true if the connection closed cleanly and false otherwise, whose code attribute is initialized to the WebSocket connection close code, and whose reason attribute is initialized to the WebSocket connection close reason decoded as UTF-8
@ghost ghost assigned majek Oct 12, 2011
@majek majek closed this as completed in 2296591 Oct 12, 2011
@majek
Copy link
Member Author

majek commented Oct 12, 2011

Also, support wasClean property.

@majek majek reopened this Oct 12, 2011
majek added a commit that referenced this issue Oct 12, 2011
@majek
#14 support wasClean property on CloseEvent
a22c578
@majek majek closed this as completed Oct 12, 2011
majek added a commit that referenced this issue Oct 12, 2011
@majek
#14 Forgot to update smoke tests.
e72a691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majek majek

Labels
None yet
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@majek