... a global context other than window.
Make the condition on `this` more accurate. In principle it might run…
… in a global context other than window.
For the reference: bc70bc2#commitcomment-2208834 @fearphage
Is this waiting for anything?
i fail to see why this issue would have any sense of urgency attached to it... i doubt that this change could yield any practical benefit. as of today, SockJS only runs in browsers, and in browsers, window is the global object. if anything, it would seem that this is merely a style change, perhaps with an eye to the future, but low priority i think.
#97 - simplify tests
@fearphage Thanks for reminders I appreciate that!
@humanchimp Yeah, no urgency, but if there is a pull request hanging I should get back to it reasonably quickly - the fault is on my side.
@squaremo I applied the patch, although I didn't merge the tests. I think that running full network tests is too heavy for this small patch. Instead I propose a basic unit test that just checks for the type of returned object.
Gosh, instanceof is not supported by IE6. Is there a workaround?
Not true: http://msdn.microsoft.com/en-us/library/ie/zh0zb36z(v=vs.94).aspx Now I'm confused! If it works I could remove the if from tests/
#97 - okay, instanceof should be working in ie
@majek Yes fair enough about the test -- thanks for correcting