Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pass all -protocol tests #8

Closed
majek opened this Issue Oct 10, 2011 · 1 comment

Comments

Projects
None yet
1 participant
Owner

majek commented Oct 10, 2011

No description provided.

@ghost ghost assigned majek Oct 10, 2011

majek added a commit that referenced this issue Oct 10, 2011

majek added a commit that referenced this issue Oct 10, 2011

#8 Cowboy headers handling is weird. Some headers are treated as atom…
…s, some as binaries.

Binaries are normalized (camel case), so requests for headers are case-sensitive.

majek added a commit that referenced this issue Oct 10, 2011

majek added a commit that referenced this issue Oct 10, 2011

#8 Unify response when callback is not set - return 'undefined'
Also, return generic error when callback is not present.

majek added a commit that referenced this issue Oct 11, 2011

#8 Be more careful about reusing Req objects.
Cowboy doesn't like (ie: 400 error) when a Req object is modified but not returned to cowboy. It apparently sockjs_http:body_qs() does modify Req and thus the modified version must be passed along.

majek added a commit that referenced this issue Oct 11, 2011

majek added a commit that referenced this issue Oct 11, 2011

Owner

majek commented Oct 18, 2011

SockJS-erlang is now passing most of the tests. The remaining ones are:

  • WebsocketHttpErrors
  • Few cowboy issues (raised: 73, 74, 75 )

Closing, it's good enough.

@majek majek closed this Oct 18, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment