Fix for R16B's removal of parameterized modules #45

Merged
merged 1 commit into from Jan 5, 2014

Conversation

Projects
None yet
4 participants

tsutsu commented Apr 14, 2013

Copy OTP's parameterized module parse-transform
(https://github.com/erlang/pmod_transform) into the source tree;
add compiler pragmas to files that require parameterized modules
to use the parse-transform (sockjs_pmod_pt).

The module implementing the parse-transform has been renamed, as
per OTP's suggestion, to avoid name clashes.

Fixes #43.

Sean Keith McAuley Fix for R16B's removal of paramaterized modules
Copy OTP's paramaterized module parse-transform
(https://github.com/erlang/pmod_transform) into the source tree;
add compiler pragmas to files that require parameterized modules
to use the parse-transform (sockjs_pmod_pt).

The module implementing the parse-transform has been renamed, as
per OTP's suggestion, to avoid name clashes.
ee7841f
Contributor

hyperthunk commented May 14, 2013

Hi @tsutsu - thanks for the patch. I'll try and attend to this in the next week or so.

Contributor

hyperthunk commented Jun 24, 2013

I'll try and attend to this in the next week or so.

Sorry, been rather busy but I will try and get to this soon.

xinuc commented Jan 3, 2014

Is there any reason this is not merged yet?
I've tried it and I didn't find any problem compiling.

majek merged commit bd9de3d into sockjs:master Jan 5, 2014

xinuc commented Jan 6, 2014

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment