API should be idiomatic #16

Closed
majek opened this Issue Oct 11, 2011 · 2 comments

Projects

None yet

1 participant

@majek
Member
majek commented Oct 11, 2011

For example event names: connect not open, end not close and so on

@majek majek was assigned Oct 11, 2011
@majek
Member
majek commented Oct 12, 2011

Let's use convention from UDP API in node:

That means: connection, messsage and close events.

@majek majek added a commit that referenced this issue Oct 12, 2011
@majek majek #16 The api should be idiomatic. Changing event signatures closer to …
…api like net.server.udp.
f0051fc
@majek majek closed this Oct 18, 2011
@majek
Member
majek commented Oct 20, 2011

Actually, we should use the streams api

@majek majek reopened this Oct 20, 2011
@majek majek added a commit that referenced this issue Oct 20, 2011
@majek majek #16 Better explanations. f70d5f3
@majek majek closed this Oct 24, 2011
@npmcomponent npmcomponent pushed a commit to npmcomponent/juliangruber-sockjs-client that referenced this issue Feb 20, 2014
@majek majek Update example to use more idiomatic sockjs-node api. 93949d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment