Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update websocket-driver Version #275

Closed
ffjanhoeck opened this issue Jul 17, 2020 · 2 comments
Closed

Update websocket-driver Version #275

ffjanhoeck opened this issue Jul 17, 2020 · 2 comments

Comments

@ffjanhoeck
Copy link

@ffjanhoeck ffjanhoeck commented Jul 17, 2020

Hey folks,

could you please verify if you can update the websocket-driver version from 0.6.5 to 0.7.4?
The update is important, because websocket-driver has a dependency called websocket-extension. This dependency had a security issue which was fixed in version 0.1.4. But to get that version, you have to update.

The issue was:

The ReDoS flaw allows an attacker to exhaust the server's capacity to process
incoming requests by sending a WebSocket handshake request containing a header
of the following form:

Sec-WebSocket-Extensions: a; b="\c\c\c\c\c\c\c\c\c\c ...

That is, a header containing an unclosed string parameter value whose content is
a repeating two-byte sequence of a backslash and some other character. The
parser takes exponential time to reject this header as invalid, and this will
block the processing of any other work on the same thread. Thus if you are
running a single-threaded server, such a request can render your service
completely unavailable.

The dependency faye-websocket also has the websocket-driver dependency.

@brycekahle
Copy link
Member

@brycekahle brycekahle commented Jul 21, 2020

Thanks for reporting this. I will take a look and get back to you.

@brycekahle
Copy link
Member

@brycekahle brycekahle commented Jul 31, 2020

0.3.21 is released. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants