Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call res.write instead of res.end in writeHead #265

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

brycekahle
Copy link
Contributor

This matches what Node.js does internally when dealing with a ServerResponse.

Fixes #252

This matches what Node.js does internally when dealing with a ServerResponse.

Fixes #252
cakoose added a commit to cakoose/sockjs-node that referenced this pull request Dec 4, 2019
@brycekahle brycekahle merged commit 86ba45a into master Mar 6, 2020
@brycekahle brycekahle deleted the fix-write-after-end branch March 6, 2020 20:41
This was referenced Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR_STREAM_WRITE_AFTER_END when issuing upgrade request on non-existent URL
1 participant