Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Call Metric.new instead of metrics.new #147

Merged
merged 1 commit into from Dec 20, 2012

Conversation

Projects
None yet
2 participants
Owner

sodabrew commented Dec 10, 2012

Calling metrics.new was duplicating all metrics, rather than only adding the one metric. Resolves this test failure:

  1) Report post transformer munging should idempotently update statuses and metrics
     Failure/Error: ]
       expected collection contained:  [["resources", "pending", 1], ["resources", "unchanged", 0]]
       actual collection contained:    [["resources", "pending", 1], ["resources", "pending", 1], ["resources", "unchanged", 0], ["resources", "unchanged", 0]]
       the extra elements were:        [["resources", "pending", 1], ["resources", "unchanged", 0]]
     # ./spec/models/report_spec.rb:103
Contributor

haus commented Dec 20, 2012

Finished in 50.377041 seconds

527 examples, 0 failures

sodabrew added a commit that referenced this pull request Dec 20, 2012

Merge pull request #147 from sodabrew/patch-2
Call Metric.new instead of metrics.new

@sodabrew sodabrew merged commit 99cd6a3 into sodabrew:master Dec 20, 2012

@sodabrew sodabrew deleted the sodabrew:patch-2 branch Dec 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment