Details report errors inside Failed tab. #176

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

This allows easy indentification of what went wrong, instead of clicking
a few times to pull up the details.

Committer: Rick van der Zwet rickvanderzwet@optiver.com

Rick van der Zwet
Report errors details in Failed Tab.
This allows easy indentification of what went wrong, instead of clicking
a few times to pull up the details.

Committer: Rick van der Zwet <rickvanderzwet@optiver.com>
Owner

sodabrew commented Feb 15, 2013

Interesting! Could you attach a cropped screen shot of how this looks in use?

Owner

sodabrew commented Apr 11, 2013

Ping @optiver-ams-operations would you mind helping to "sell" this feature with a small screenshot of it in action?

@ghost

ghost commented Apr 11, 2013

tothegithub
If im not mistaken, Rick means the added field at the bottom of the image.

Signed,
His colleague :)

@@ -0,0 +1,36 @@
+- nodes = paginate_scope(local_assigns[:nodes])
@sodabrew

sodabrew Apr 11, 2013

Owner

I don't think you need local_assigns here -- nodes = paginate_scope(nodes) should work.

@@ -18,3 +18,7 @@
.section
%h3 Nodes
= render 'nodes', :nodes => @nodes, :selected_status => action_name
+ - if action_name == 'failed'
@sodabrew

sodabrew Apr 11, 2013

Owner

Should it only be the failed nodes display that gets this? The general nodes overview might benefit from a quick view of failures as well. (But I'm not sure.)

Owner

sodabrew commented Apr 16, 2013

Please rebase your branch off rails3 and open a new PR for consideration in the next Dashboard major. You may also need a CLA with Puppet Labs before I can merge the PR.

Owner

sodabrew commented Apr 24, 2013

Also, the new file _log_detail.html.haml is very similar to app/views/reports/_log.html.haml -- only Hostname is added as a column -- could you take a look at merging up these templates instead of duplicating?

kbrezina pushed a commit to kbrezina/puppet-dashboard that referenced this pull request Oct 18, 2013

Merge pull request #176 from haus/ticket/2.8.x/re_453_2.8.x_pe_packaging
(RE-453) Make a 2.8.x branch for pe-puppet-dashboard
Owner

sodabrew commented Jan 9, 2014

Merged as c255a3d

@sodabrew sodabrew closed this Jan 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment