Fix start coordinate in SAM#953
Merged
martin-steinegger merged 1 commit intoFeb 28, 2025
Merged
Conversation
Author
|
@martin-steinegger wanted to follow up on this - not sure why the FreeBSD-13 test failed but does this look good to you? Thanks for your consideration! |
Member
|
Yes this looks good to me. Thank you for fixing it! |
Author
|
Thanks for accepting it! Possible to tag a release soon to incorporate it? |
Member
|
Not quite sure when we will tag the next release, but in the meantime you can use precompiled binaries at https://mmseqs.com/latest/ or for specific commits at https://mmseqs.com/archive/91462b10129740320ad201333b6f309f09e91b6d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #952
Not sure why I missed this line when opening the issue. Wasn't sure if we should take
minof start and end or useforwardto decide whether we take start or end. This seems to work. Thanks for your consideration!