Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaBaseTopology][SofaExporter] Fix failing tests due to changes in topology #1335

Merged
merged 5 commits into from Apr 16, 2020

Conversation

hugtalbot
Copy link
Contributor

Fix tests further to #1323

  • SofaExporter_test was expecting to export Hexa while option computeHexa was false in RGrid
  • RegularGridTopology_test was expecting the wrong number of edges since the computation is now under the condition whether the triangles are used or not to compute the edges

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Apr 15, 2020
@hugtalbot hugtalbot requested a review from epernod April 15, 2020 21:51
@hugtalbot hugtalbot self-assigned this Apr 15, 2020
@guparan guparan added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Apr 16, 2020
@hugtalbot
Copy link
Contributor Author

did you apply the clang auto-format or are these manual changes? @guparan

@guparan
Copy link
Contributor

guparan commented Apr 16, 2020

I quickly applied a simple formatter online and finished manually. This file was a mess.

@epernod
Copy link
Contributor

epernod commented Apr 16, 2020

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor Author

Is everything good for you then @epernod ?

@epernod
Copy link
Contributor

epernod commented Apr 16, 2020

you didn't answer my last question regarding change of name: TEST_P(RegularGridTopology_test, regularGridSizeComputeEdgeFromTriangle)

@hugtalbot
Copy link
Contributor Author

hugtalbot commented Apr 16, 2020

@epernod I needed to have two different names for the same test:

  • one when edges are computed from an existing triangle topology
  • and one when edges are computed from hexa.

@epernod epernod merged commit 2ff6c2a into sofa-framework:master Apr 16, 2020
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
@guparan guparan changed the title [Tests] Fix failing tests due to changes in topology [SofaBaseTopology][SofaExporter] Fix failing tests due to changes in topology Jun 16, 2020
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants