New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaBaseTopology][SofaExporter] Fix failing tests due to changes in topology #1335
Conversation
did you apply the clang auto-format or are these manual changes? @guparan |
I quickly applied a simple formatter online and finished manually. This file was a mess. |
SofaKernel/modules/SofaBaseTopology/SofaBaseTopology_test/RegularGridTopology_test.cpp
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseTopology/SofaBaseTopology_test/RegularGridTopology_test.cpp
Show resolved
Hide resolved
[ci-build][with-all-tests] |
Is everything good for you then @epernod ? |
you didn't answer my last question regarding change of name: |
@epernod I needed to have two different names for the same test:
|
Fix tests further to #1323
This PR:
Reviewers will merge only if all these checks are true.