[SofaKernel] FIX PluginManager::pluginIsLoaded #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is not behaving as it name suggest and does not detect plugin that have not been loaded using the pluginManager.
damienmarchal
added
pr: status to review
fredroy
added
pr: status ready
guparan
added
pr: status to review
guparan
suggested changes
Dec 2, 2020
SofaKernel/modules/SofaHelper/src/sofa/helper/system/PluginManager.cpp
Outdated
Show resolved
Hide resolved
|
@guparan the suggested changed has been made. |
guparan
added
pr: status ready
guparan
approved these changes
Dec 2, 2020
guparan
pushed a commit
that referenced
this pull request
Dec 8, 2020
* [SofaKernel] FIX PluginManager::pluginIsLoaded The function is not behaving as it name suggest and does not detect plugin that have not been loaded using the pluginManager. * Update PluginManager.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function pluginIsLoaded is not behaving as it name suggest and does not detect plugin that have not been loaded using an absolute file path.
See:
SofaDefrost/plugin.SofaPython3.deprecated#137
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if