FIX warnings #229
Merged
FIX warnings #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings were due to unused function and overwriting function (clang)
hugtalbot
added
pr: fast merge
|
The compilation on win7_VS-2015 is running out of heap space. |
|
[ci-build] |
1 similar comment
|
[ci-build] |
damienmarchal
added
the
pr: status ready
guparan
reviewed
Apr 10, 2017
| @@ -202,7 +202,7 @@ class BilateralInteractionConstraintSpecialization<RigidImpl> | |||
| const helper::vector<int> &m2Indices = self.m2.getValue(); | |||
|
|
|||
| unsigned min = std::min(m1Indices.size(), m2Indices.size()); | |||
| const typename BilateralInteractionConstraint<T>::VecDeriv& restVector = self.restVector.getValue(); | |||
| // const typename BilateralInteractionConstraint<T>::VecDeriv& restVector = self.restVector.getValue(); | |||
There was a problem hiding this comment.
I'm not a big fan of commented code, it's hard to maintain.
Shouldn't this be simply deleted?
guparan
removed
the
pr: status ready
|
hey @matthieu-nesme could you have a look at my last commit about BilateralInteractionConstraint. Do you agree with the RigidImpl ? |
|
I do not use and do not know BilateralInteractionConstraint. |
|
Alright, so as soon as centos is done. Ready to merge. |
hugtalbot
added
the
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings were due to unused function and overwriting function (clang)
This PR:
Reviewers will merge only if all these checks are true.