New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaMiscFem] Add hyperelasticity fem code in SOFA #349

merged 7 commits into from Aug 23, 2017


Copy link

hugtalbot commented Jul 27, 2017

This PR adds finally hyperelasticity code in SOFA!
Related to issue : #231

Based on the work of @hdeling with @IPeterlik six new hyperelastic models (linearized or non-linear constitutive law) can now be used:

  • ArrudaBoyce
  • StVenant
  • Mooney-Rivlin
  • VerondaWestman
  • Costa
  • Ogden

Note that a validation of such models was done in this paper.
More about this can be found on the SOFA website.

TODO next :

  • improve how parameters are given, stored
  • allow for non-homogeneous model (definition per tetra)
  • add associated test

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

htalbot added some commits Jul 18, 2017

Add a first hyperelastic model opensource in SOFA
This work has been done by hdeling and proposed a non-optimized
implementation of hyperelastic consistitutive law (in SofaMiscFem).
This commit includes an example.
param_vector[0] = 151065.460; //C01
param_vector[1] = 101709.668; //C10
param_vector[2] = 1e07; //K0

This comment has been minimized.


guparan Aug 2, 2017


Not a big fan of magic numbers. Could we use some constants here?

This comment has been minimized.


hugtalbot Aug 7, 2017


Those are values used obtained from a real mechanical experiment.
This numerical test reproduces this experiment.
I could add a comment if you like


This comment has been minimized.

Copy link

hugtalbot commented Aug 16, 2017

this PR should be ready, as the author, I won't mark it myself as ready nor merge it


This comment has been minimized.

Copy link

guparan commented Aug 21, 2017


@guparan guparan merged commit 1949db2 into sofa-framework:master Aug 23, 2017

4 of 5 checks passed

centos_clang-3.4_options Build queued.
Dashboard Builds triggered.
mac_clang-3.4_options OK (test ignored, see details)
ubuntu_gcc-5.4_options OK (test ignored, see details)
windows7_VS-2015_options_amd64 OK (test ignored, see details)

matthieu-nesme added a commit to Anatoscope/sofa that referenced this pull request Sep 6, 2017

Merge pull request sofa-framework#349 from hugtalbot/add_hyperelastic…

[SofaMiscFem] Add hyperelasticity fem code in SOFA
Fixes sofa-framework#231
(cherry picked from commit 1949db2)

@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017

@guparan guparan added this to the v17.12 milestone Sep 13, 2017

@hugtalbot hugtalbot deleted the hugtalbot:add_hyperelasticityFEM_code_from_hdeling branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment