[all] Fix default value rayleigh params #350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #338
The Rayleigh parameters (Rayleigh mass and stiffness) are used for numerical dumping in the simulation. However, most integration schemes (OdeSolvers) in SOFA use NON-ZERO default values.
This commit fixes this.
The user must be aware of its dumping parameters, now :
To avoid breaking all scenes, this PR also updates (where needed) the rayleighMass and
rayleighStiffness parameter (set to 0.1 like previous default values).
NOTE : a script is available for updating all your own scenes if needed (script/update-scenes-rayleighcoeff.sh)
This PR:
Reviewers will merge only if all these checks are true.