Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Fix default value rayleigh params #350

Merged

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Jul 27, 2017

See issue: #338
The Rayleigh parameters (Rayleigh mass and stiffness) are used for numerical dumping in the simulation. However, most integration schemes (OdeSolvers) in SOFA use NON-ZERO default values.

This commit fixes this.
The user must be aware of its dumping parameters, now :

  • default rayleighMass=0.0
  • default rayleighStiffness=0.0

To avoid breaking all scenes, this PR also updates (where needed) the rayleighMass and
rayleighStiffness parameter (set to 0.1 like previous default values).

NOTE : a script is available for updating all your own scenes if needed (script/update-scenes-rayleighcoeff.sh)


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

htalbot added 2 commits July 27, 2017 15:41
The Rayleigh parameters (Rayleigh mass and stiffness) are used
for numerical dumping in the simulation. However, most integration
schemes in SOFA use NON-ZERO default values. This commit fixes this.
The user must be aware of its dumping parameters.
This commit adds where needed the rayleighMass and
rayleighStiffness parameter (0.1 both) in all scenes.
@hugtalbot hugtalbot added enhancement About a possible enhancement pr: clean Cleaning the code project : Validation labels Jul 27, 2017
@hugtalbot hugtalbot self-assigned this Jul 27, 2017
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Jul 27, 2017
@hugtalbot
Copy link
Contributor Author

youhou @guparan the CI is back on feet!

@guparan
Copy link
Contributor

guparan commented Jul 28, 2017

Let's try something new: [ci-build] [with-scene-tests] 😉

@guparan
Copy link
Contributor

guparan commented Aug 2, 2017

One more time! [ci-build] [with-scene-tests]

@hugtalbot
Copy link
Contributor Author

[ci-build] [with-scene-tests]

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Aug 9, 2017
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress labels Aug 9, 2017
@hugtalbot hugtalbot merged commit 1a3e4a2 into sofa-framework:master Aug 11, 2017
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
@hugtalbot hugtalbot deleted the fix_default_value_Rayleigh_params branch January 3, 2018 14:37
@guparan guparan added this to Doing in Validation via automation Apr 16, 2020
@guparan guparan moved this from Doing to Done in Validation Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
Validation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants