Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[SofaVolumetricData] Split the module into multiple plugin #389
This PR is here to support Issue #388
This is the beginning of a work on cleaning and modularizing the
A third plugin act as a transitional package SofaVolumetricData guiding
Reviewers will merge only if all these checks are true.
@untereiner thank for the question.
What I would dream of some kind of consensus about how we proceed and I'm totally open for suggestions.
I see the goods of making smooth transition in a code base (user of the code base will praise you) and the bad of maintaining the transitional package.
On my side... I would say:
Hi @damienmarchal, thank you for this massive work.
Thanks you all the for the feedback.
I appologize about the reviewing work. And you are right, this one is very hard. We can also be a bit more "lazy" in the reviewing, merging it, write a good changelog a tell people to send feedback if something goes wrong.
I'm pushing this one because we have a nice other PR waiting and this one have new cool features (from distance field modeling to tetrahedral meshing).
EDIT: actually moving from module to plugins without refactoring is much easier...but well... I was not able to prevent me.