New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaGUI] Move GlutGUI to projects and remove all glut references in SofaFramework #598

Merged
merged 5 commits into from Mar 5, 2018

Conversation

3 participants
@fredroy
Copy link
Contributor

fredroy commented Feb 22, 2018

Glut is a deprecated library and in my opinion, should be not used anymore. (not compatible with newer version of OpenGL, etc)
It can be replaced with GLFW to create quick graphical applications.

This first PR is moving the SofaGuiGlut to the applications directory, in case any people are still using it.
Actually, the code was not compatible with the current SofaGui API and was not compiling.
The code is now compilable and launchable anyway.

Any reference to Glut are removed from the SofaFramework (header, CMake) and from runSofa.

Lastly, a replacement using gflw will be pushed in the near future, for people wishing to have a simple GUI without the heavy-duty Qt Framework.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added the pr: clean label Feb 22, 2018

@fredroy fredroy changed the title [SofaGUI] Move GlutGUI to projects and remove all glut reference in SofaFramework [SofaGUI] Move GlutGUI to projects and remove all glut references in SofaFramework Feb 22, 2018

@hugtalbot

This comment has been minimized.

Copy link
Contributor

hugtalbot commented Feb 25, 2018

[ci-build][with-scene-tests]

## Glut GUI
find_package(GLUT)
if(GLUT_FOUND)
sofa_add_application(SofaPhysicsAPI SofaPhysicsAPI)

This comment has been minimized.

@guparan

guparan Feb 26, 2018

Member

Would be better to add every app disabled and let them fail when running find_package(GLUT REQUIRED) if enabled, no?
I don't think this CMakeLists should be smartly checking GLUT_FOUND. It's not its dependency.

This comment has been minimized.

@fredroy

fredroy Feb 27, 2018

Contributor

I was wondering the same, but I was lazy to add the check in all the projects needing glut.
But I guess you are right so I will add it in those projects directly

@guparan guparan merged commit 9ba3ddb into sofa-framework:master Mar 5, 2018

5 of 6 checks passed

ubuntu_gcc-5.4_options Build queued.
Details
Dashboard Builds triggered.
Details
Scene tests Triggered in latest build.
Details
centos_clang-3.4_options OK (tests ignored, see details)
Details
mac_clang-3.4_options OK (tests ignored, see details)
Details
windows7_VS-2015_options_amd64 OK (tests ignored, see details)
Details

@guparan guparan added this to the v18.06 milestone Apr 5, 2018

@guparan guparan referenced this pull request Jun 5, 2018

Merged

[CMake] Improve SOFA installation and packaging #635

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment