Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX collision of the fontain example #612

Merged
merged 1 commit into from Mar 21, 2018
Merged

FIX collision of the fontain example #612

merged 1 commit into from Mar 21, 2018

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Mar 15, 2018 •
edited by guparan

Add just a collision model (Sphere to have collision in the default fontain.scn example of the SofaPython example.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 15, 2018
@hugtalbot hugtalbot requested a review from guparan March 15, 2018 08:35
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 21, 2018
@guparan guparan merged commit a5ed005 into sofa-framework:master Mar 21, 2018
@guparan guparan added this to the v18.06 milestone Apr 5, 2018
@hugtalbot hugtalbot deleted the fix_fontain_Example_collision branch September 21, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugtalbot @guparan