Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluginize SofaSparseSolver & SofaPreconditoner #663

Closed

Conversation

1 participant
@damienmarchal
Copy link
Contributor

commented May 23, 2018

As said in the title this PR puts SofaSparseSolver and SofaPreconditioner in plugins.

There was #define SOFA_HAVE_METIS/SOFA_HAVE_CSPARSE in config.h instead of using
find_package to detect and activate conditional building depending on dependencies. I replaced this mechanisme by using find_package(Metis) which I found more clear.

NB: the PR is in wip as I want to check it is going in the same direction as SofaNG
NB2: it may also be a good idea to add some unittest as SparseLDLSolver seems to be used (So @olivier-goury, @IPeterlik , @marques-bruno, @EulalieCoevoet if you have 1 hour to give feel free ;))


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2018

[ci-build][with-scene-tests]

@damienmarchal

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2018

I close this one to open a new one without the move to plugin directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.