New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaGraphComponent] FIX SceneCheck build on MacOS #719

Merged
merged 2 commits into from Jul 23, 2018

Conversation

3 participants
@guparan
Copy link
Member

guparan commented Jul 16, 2018

CI info: I disabled Defrost MacOS builder to force this PR to build on sofa-ci-dev-macos.

To be merged asap (if CI agrees).


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Jul 16, 2018

[ci-build]

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Jul 16, 2018

Build failed with old error already seen in build 220.

@epernod

This comment has been minimized.

Copy link
Contributor

epernod commented Jul 17, 2018

[ci-build]

just testing if the problem is due to the lib.
Will rebase if not.

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Jul 17, 2018

Well done @epernod !

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Jul 17, 2018

Could someone test if the AdvancedTimer is still working correctly with the new nlohmann_json version?
@jnbrunet @fredroy @damienmarchal ?

@epernod

This comment has been minimized.

Copy link
Contributor

epernod commented Jul 17, 2018

No regression test on the advanceTimer? ;)

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Jul 20, 2018

Ready to merge.

@epernod

This comment has been minimized.

Copy link
Contributor

epernod commented Jul 20, 2018

green green green!!!

@epernod

This comment has been minimized.

Copy link
Contributor

epernod commented Jul 20, 2018

[ci-build][with-scene-tests]

@epernod epernod merged commit d7ccf3c into sofa-framework:master Jul 23, 2018

6 checks passed

Jk2/Dashboard Builds triggered.
Details
Jk2/Scene tests Triggered in latest build.
Details
Jk2/centos_clang-3.4_options Build OK. FIXME: 1 unit tests, 0 scene tests
Details
Jk2/mac_clang-3.5_options Build OK. FIXME: 51 unit tests, 12 scene tests
Details
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit tests, 1 scene tests
Details
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 2 unit tests, 2 scene tests
Details

@guparan guparan deleted the guparan:fix_scenecheck_macos_build branch Oct 1, 2018

@guparan guparan added the pr: backport label Oct 4, 2018

@guparan guparan added this to the v18.06 milestone Oct 4, 2018

guparan added a commit to guparan/sofa that referenced this pull request Oct 4, 2018

Merge pull request sofa-framework#719 from guparan/fix_scenecheck_mac…
…os_build

[SofaGraphComponent] FIX SceneCheck build on MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment