New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaKernel] BREAKING: Replacing DataEngine with SimpleDataEngine #814

Merged
merged 8 commits into from Nov 21, 2018

Conversation

2 participants
@marques-bruno
Copy link
Member

marques-bruno commented Nov 8, 2018

Fix #809
Following the STC decision to replace the DataEngine with the SimpleDataEngine, here's the PR that does just that.

This replacement involves taking every engine in Sofa and:

  • replacing its update() method with the new delegate doUpdate().
  • Remove the calls to data.isDirty() and (smartly) replacing them with m_dataTracker.isDirty(data)
  • Remove the cleanDirty() calls while making sure we don't break the engine's behavior

Most engines present in SOFA are either in SofaGeneralEngine or SofaMiscEngine.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

marques-bruno added some commits Nov 8, 2018

[DataUpdate][SofaGeneralEngine] FIX: Removing call to update on input…
… field that's been made useless by new DataEngine impl
@marques-bruno

This comment has been minimized.

Copy link
Member Author

marques-bruno commented Nov 8, 2018

Default CMake build compiles, now all the plugins, and disabled options that activate code using DataEngines need to be activated to propagate that change.
I'm counting on you...!

@marques-bruno marques-bruno added the STC#6 label Nov 9, 2018

@marques-bruno

This comment has been minimized.

Copy link
Member Author

marques-bruno commented Nov 12, 2018

[ci-build]

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Nov 14, 2018

[ci-build][with-scene-tests]

@guparan guparan merged commit 2a1a434 into master Nov 21, 2018

6 checks passed

Jk2/Dashboard Builds triggered.
Details
Jk2/Scene tests Triggered in latest build.
Details
Jk2/centos_clang-3.4_options Build OK. FIXME: 1 unit tests, 0 scene tests
Details
Jk2/mac_clang-3.5_options Build OK. FIXME: 0 unit tests, 1 scene tests
Details
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit tests, 0 scene tests
Details
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 2 unit tests, 1 scene tests
Details

@guparan guparan changed the title [Data Update] [SofaKernel] BREAKING: Replacing DataEngine with SimpleDataEngine [SofaKernel] BREAKING: Replacing DataEngine with SimpleDataEngine Nov 21, 2018

untereiner added a commit to mimesis-inria/sofa that referenced this pull request Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment