New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataUpdates][BREAKING] Rename: data tracker has changed #822

Merged
merged 5 commits into from Nov 23, 2018

Conversation

@marques-bruno
Copy link
Member

marques-bruno commented Nov 9, 2018

Depends #814
This PR renames DataTrackerDDGNode's isDirty() method to hasChanged() to reduce confusion between hasChanged and BaseData::isDirty().

It depends on #814 because replacing update with doUpdate forces the replacement of calls to data.isDirty() with m_dataTracker.isDirty(data) which means some extra calls are added in #814


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@marques-bruno marques-bruno added this to the v18.12 milestone Nov 9, 2018

@marques-bruno marques-bruno self-assigned this Nov 9, 2018

@marques-bruno

This comment has been minimized.

Copy link
Member Author

marques-bruno commented Nov 12, 2018

[ci-build]

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Nov 14, 2018

@marques-bruno Please update/enhance the Doxygen for both methods 😉

@marques-bruno

This comment has been minimized.

Copy link
Member Author

marques-bruno commented Nov 14, 2018

I'll switch it back to to_review, but it's not to be merged before #814

@guparan

This comment has been minimized.

Copy link
Member

guparan commented Nov 21, 2018

[ci-build][with-scene-tests]

@marques-bruno

This comment has been minimized.

@marques-bruno

This comment has been minimized.

Copy link
Member Author

marques-bruno commented Nov 23, 2018

[ci-build][with-scene-tests]

@guparan guparan merged commit d9c9f70 into master Nov 23, 2018

6 checks passed

Jk2/Dashboard Builds triggered.
Details
Jk2/Scene tests Triggered in latest build.
Details
Jk2/centos_clang-3.4_options Build OK. FIXME: 0 unit tests, 0 scene tests
Details
Jk2/mac_clang-3.5_options Build OK. FIXME: 1 unit tests
Details
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit tests, 0 scene tests
Details
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 2 unit tests, 0 scene tests
Details

@guparan guparan deleted the rename_DataTracker_hasChanged branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment