Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaTopologyMapping] Clean, fix, upgrade Triangle2EdgeTopologicalMapping #875

merged 16 commits into from Jan 11, 2019


3 participants
Copy link

commented Dec 24, 2018

  • Clean Triangle2EdgeTopologicalMapping
  • Fix TopologySparseDataHandler swap and remove methods
  • Add new regression test, to test add/remove of triangle with and without Triangle2EdgeTopologicalMapping

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod force-pushed the epernod:topo_mapping branch from 9d97ac8 to 7782313 Dec 25, 2018


This comment has been minimized.

Copy link
Contributor Author

commented Dec 31, 2018


[TopologyMapping] Add Pointer to EdgeSetTopologyModifier in Triangle2…
…EdgeTopologyMapping. In order to check if component is in present at init and do not search for it at each handleSetTopologyEvent.

@epernod epernod changed the title [SofaTopologyMapping] Clean Triangle2EdgeTopologicalMapping [SofaTopologyMapping] Clean, fix, upgrade Triangle2EdgeTopologicalMapping Jan 2, 2019

[SofaTopologyMapping] Update: remove unnecessary call to propagateTop…
…ologicalChanges and remove commented code.

@hugtalbot hugtalbot merged commit ef2facf into sofa-framework:master Jan 11, 2019

7 checks passed

Jk2/Dashboard Builds triggered.
Jk2/[with-regression-tests] Triggered in latest build.
Jk2/[with-scene-tests] Triggered in latest build.
Jk2/centos_clang-5_options Build OK. FIXME: 0 unit tests, 4 scene tests 5 regressions
Jk2/mac_clang-3.5_options Build OK. FIXME: 1 unit tests, 6 scene tests 5 regressions
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit tests, 4 scene tests 4 regressions
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 1 unit tests, 4 scene tests 4 regressions

@guparan guparan added this to the v19.06 milestone Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.