Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaTopologyMapping] Clean, fix, upgrade Tetra2TriangleTopologicalMapping #876

merged 13 commits into from Jan 18, 2019


2 participants
Copy link

commented Jan 2, 2019

Clean, Fix, Upgrade, Harder, Better, Stronger...

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

epernod added some commits Sep 26, 2018

[SofaTopologyMapping] Change the TriangleRemoved event code to first …
…compute the list of triangle to remove in the toTopology and then update the map. Thus removeTriangles procress is only perform once instead of for each triangle.
[TopologyMapping] Clean and Update init method of Tetra2TriangleTopol…
…ogicalMapping. Check input/output models and update its componentState. Only test componentState in other methods.

epernod added some commits Jan 2, 2019

[TopologyMapping] Add Pointer to TriangleSetTopologyModifier in Tetra…
…2TriangleTopologyMapping. In order to check if component is in present at init and do not search for it at each handleSetTopologyEvent.

@epernod epernod changed the title [SofaTopologyMapping] Clean, fix and upgrade Tetra2TriangleTopologicalMapping [SofaTopologyMapping] Clean, fix, upgrade Tetra2TriangleTopologicalMapping Jan 2, 2019


This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019


epernod added some commits Jan 3, 2019

[SofaGeneralSimpleFEM] Fix tetrahedralCorotational init, if topology …
…is null invalid component but if topology is empty at start still create the topologyEngine.
[regression-test] Add Adding/Removing tetra and tetra2triangle scenes…
… to the topology non regression tests.

@guparan guparan merged commit 815ff0e into sofa-framework:master Jan 18, 2019

7 checks passed

Jk2/Dashboard Builds triggered.
Jk2/[with-regression-tests] Triggered in latest build.
Jk2/[with-scene-tests] Triggered in latest build.
Jk2/centos_clang-5_options Build OK. FIXME: 0 unit tests, 4 scene tests 6 regressions
Jk2/mac_clang-3.5_options Build OK. FIXME: 1 unit tests, 11 scene tests 6 regressions
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit tests, 4 scene tests 5 regressions
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 1 unit tests, 4 scene tests 5 regressions

@guparan guparan added this to the v19.06 milestone Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.