Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaKernel] Clean & Fix TopologyChangeVisitor and StateChangeVisitor behavior #880

merged 5 commits into from Jan 11, 2019


3 participants
Copy link

commented Jan 4, 2019

This should fix all the scene crashing when performing topological change with some mechanicalMapping in the scene.

Like for example identityMapping between the mechanicalObject and the OglModel.

This is a temporary fix. Those 2 visitors will be removed as soon as all the component listed in #810 will be updated to use TopologicalData.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

epernod added some commits Jan 4, 2019

[SofaKernel] Fix: mechanicalMapping need to be updated when Mechanica…
…lObject has been resized. Until all the process go through Data graph add a direct call to mechanicalMapping handleTopologcyChange in StateChangeVisitor.

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019


@damienmarchal damienmarchal merged commit 354c76c into sofa-framework:master Jan 11, 2019

7 checks passed

Jk2/Dashboard Builds triggered.
Jk2/[with-regression-tests] Triggered in latest build.
Jk2/[with-scene-tests] Triggered in latest build.
Jk2/centos_clang-5_options Build OK. FIXME: 0 unit tests, 5 scene tests 11 regressions
Jk2/mac_clang-3.5_options Build OK. FIXME: 1 unit tests, 6 scene tests 5 regressions
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit tests, 5 scene tests 10 regressions
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 1 unit tests, 6 scene tests 5 regressions

@epernod epernod deleted the epernod:topo_visitor branch May 4, 2019

@guparan guparan added this to the v19.06 milestone Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.