Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaBaseTopology] Fix right setDirty/clean topologyData #889

merged 5 commits into from Jan 22, 2019


3 participants
Copy link

commented Jan 14, 2019

Cherry pick last useful changes from PR #788

All topologyData were set to dirty as soon as a topology modification was done. Check the Data link and set/clean dirty only topologyData link to the topology array modified.

NB: factorisation will be done as soon as everything work fine. Having several methods per topology make my eyes cry but it helps to follow the data link for debug.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

epernod added some commits Dec 19, 2018

[SofaKernel] Fix: TriangleSetTopology propagateTopologycalEngine meth…
…od to update only engines linked to triangles Data.
[SofaBaseTopology] Update method SetContainerTopologyToDirty to set a…
…ll children topology engine to dirty. Add security loop to clean topology engine into cleanContainerTopologyFromDirty.
[SofaBaseTopology] Remove set dirty of all topology engines. This is …
…now done when topology buffer is set to dirty.

@epernod epernod self-assigned this Jan 14, 2019

@epernod epernod referenced this pull request Jan 14, 2019


[SofaBaseTopology] Dynamic topology work #788

0 of 6 tasks complete

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019


@guparan guparan merged commit fa74d92 into sofa-framework:master Jan 22, 2019

7 checks passed

Jk2/Dashboard Builds triggered.
Jk2/[with-regression-tests] Triggered in latest build.
Jk2/[with-scene-tests] Triggered in latest build.
Jk2/centos_clang-5_options Build OK. FIXME: 1 unit tests, 0 scene tests 6 regressions
Jk2/mac_clang-3.5_options Build OK. FIXME: 1 unit tests, 16 scene tests 6 regressions
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit tests, 0 scene tests 5 regressions
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 1 unit tests, 1 scene tests 5 regressions

@epernod epernod deleted the epernod:topology_cleaning branch May 4, 2019

@guparan guparan added this to the v19.06 milestone Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.