Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaMeshCollision] Fix TriangleModel to handle topology changes #903

merged 11 commits into from Feb 13, 2019


3 participants
Copy link

commented Jan 22, 2019

Fix crash when removing triangles in scene using TriangleModel component.

Clean and comment the class while undusting it (sorry hard to read the diff)

  • remove serr/sout
  • change all protected members prefix
  • rewritte init and updateFromTopology methods
  • Remove the handleTopologyChange method. As this class use directly the topology buffers, no need neither for TopologyData. Just check the topology revision and update the component if topology has changed.
  • Update RemovingTrianglesProcess and AddingTrianglesProcess tests scenes to test the TriangleModel

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.


This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019


[SofaMeshCollision]Update TriangleModel test on topology. Always upda…
…te mesh component when revision has changed.

@damienmarchal damienmarchal merged commit 963b5dd into sofa-framework:master Feb 13, 2019

7 checks passed

Jk2/Dashboard Builds triggered.
Jk2/[with-regression-tests] Triggered in latest build.
Jk2/[with-scene-tests] Triggered in latest build.
Jk2/centos_clang-5_options Build OK. FIXME: 0 unit tests, 31 scene tests 8 regressions
Jk2/mac_clang-3.5_options Build OK. FIXME: 1 unit tests, 32 scene tests 8 regressions
Jk2/ubuntu_gcc-5.4_options Build OK. FIXME: 1 unit tests, 31 scene tests 7 regressions
Jk2/windows7_VS-2015_options_amd64 Build OK. FIXME: 0 unit tests, 31 scene tests 7 regressions

@guparan guparan added this to the v19.06 milestone Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.