Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaTopologyMapping] Fix crashes in Tetra2TriangleTopologicalMapping #960

Merged
merged 5 commits into from Mar 22, 2019

Conversation

2 participants
@epernod
Copy link
Contributor

commented Mar 8, 2019

Several crashes possible in Tetra2TriangleTopologicalMapping when removing tetrahedron.

  • When removing the last elements
  • When using noInitialTriangles or noNewTriangles options.

Will fix issue #954


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

[ci-build][with-all-tests]

[regression_tests] Add a second test on Tetra2TriangleTopologicalMapp…
…ing when removing tetra with mapping specific options.
@epernod

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

[ci-build][with-all-tests]

@guparan guparan merged commit 5e7d846 into sofa-framework:master Mar 22, 2019

7 checks passed

Dashboard Builds triggered.
Details
[with-regression-tests] Triggered in latest build.
Details
[with-scene-tests] Triggered in latest build.
Details
centos_clang-5_options Build OK. FIXME: 1 unit, 3 scene, 4 regression
Details
mac_clang-3.5_options Build OK. FIXME: 2 unit
Details
ubuntu_gcc-5.4_options Build OK. FIXME: 1 unit, 3 scene, 3 regression
Details
windows7_VS-2015_options_amd64 Build OK. FIXME: 2 unit, 0 scene, 3 regression
Details

@epernod epernod deleted the epernod:topo_mapping branch Mar 29, 2019

@guparan guparan added this to the v19.06 milestone Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.