[SofaExporter] FIX: out-of-tree include of SofaExporter header files #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marques-bruno
added
the
pr: status to review
|
[ci-build][with-all-tests] |
|
guparan
added
pr: fix
marques-bruno
added
pr: status to review
hugtalbot
reviewed
Apr 10, 2019
| @@ -8,4 +8,6 @@ if(NOT TARGET SofaExporter) | |||
| include("${CMAKE_CURRENT_LIST_DIR}/SofaExporterTargets.cmake") | |||
| endif() | |||
|
|
|||
| # set(@PROJECT_NAME@_INCLUDE_DIRS @CMAKE_CURRENT_SOURCE_DIR@/src/) | |||
marques-bruno
added
pr: status ready
guparan
reviewed
Apr 17, 2019
| @@ -99,7 +99,9 @@ target_compile_options(${PROJECT_NAME} PRIVATE "-DSOFA_BUILD_CIMGPLUGIN") | |||
| target_link_libraries(${PROJECT_NAME} SofaCore ${EXTERNAL_LIBS}) | |||
| target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>/include") | |||
| target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>") | |||
| target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/..>") | |||
There was a problem hiding this comment.
I think it kind of is:
There's .h & .cpp files present directly in CImgPlugin dir, so if, from external code, you want to include CImgPlugin.h for instance, by typing: #include <CImgPlugin/CImgPlugin.h> you'd have to include ../ no?
guparan
added
pr: status to review
|
@guparan: Looks like it's used also that way in the SOFA codebase. How should I proceed? should I put back the include of |
marques-bruno
added
pr: status to review
hugtalbot
added
pr: status wip
guparan
added
pr: status ready
guparan
approved these changes
Apr 26, 2019
|
Let me know if my latest commit broke something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to include the SofaExporter module in an external project (out-of-tree build of a plugin || test) was not functional since include directories were not exposed properly.
I took inspiration from CImgPlugin for this PR, which uses CMAKE_CURRENT_SOURCE_DIR to expose the target's include directory.. but I believe this is actually wrong as this corresponds to the path to the sources (
/home/bruno/dev/sofa/modules/SofaExporter/src/in my case for instance) and not to the installed include directory, (which should be/home/bruno/dev/sofa/build/install/include/SofaExporter/src/SofaExporteron my machine)I took a look at other plugins & pluginized modules & they all seem to do this, so Idk if it's a mistake or done on purpose..?
This PR:
Reviewers will merge only if all these checks are true.