Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaTopologicalMapping] Yet another fix in Tetra2triangleTopologicalMapping #998

merged 3 commits into from Apr 24, 2019


3 participants
Copy link

commented Apr 18, 2019

  • Tetra2TriangleTopologicalMapping: Fix addTetrahedron case in tetra2TriangleTopologicalMapping for a tricky add + remove border triangles case.
  • Update scene tests
  • TriangleSetTopologyModifier: Add more check in AddTriangle methods.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

epernod added some commits Apr 16, 2019

[SofaBaseTopology] Add checkTopology methods in addTriangles method i…
…n triangle modifier and use this method in tetra2triangle mapping
[SofaTopologicalMapping] Fix addTetrahedron case in tetra2Triangle ma…
…pping.. for tricky add + remove border triangles cases

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019


@damienmarchal damienmarchal merged commit ca00bdb into sofa-framework:master Apr 24, 2019

7 checks passed

Dashboard Builds triggered.
[with-regression-tests] Triggered in latest build.
[with-scene-tests] Triggered in latest build.
centos_clang-5_options Build OK. FIXME: 0 unit, 0 scene, 4 regressions
mac_clang-3.5_options Build OK. FIXME: 1 unit, 1 scene, 4 regressions
ubuntu_gcc-5.4_options Build OK. FIXME: 0 unit, 0 scene, 3 regressions
windows7_VS-2015_options_amd64 Build OK. FIXME: 1 unit, 1 scene, 3 regressions

@guparan guparan added this to the v19.06 milestone Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.