Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a typo in configs/README.md #793

Closed
wants to merge 1 commit into from

Conversation

felixonmars
Copy link

Issues associated with this PR

Your PR should present related issues you want to solve.

Sign the CLA

Make sure you have signed the CLA

Solutions

You should show your solutions about the issues in your PR, including the overall solutions,
details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases.
And you need to show the ut result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result

Code Style

  • Make sure Goimports has run
  • Show Golint result

@sofastack-bot
Copy link

sofastack-bot bot commented Aug 22, 2019

Hi @felixonmars, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #793 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
- Coverage   51.64%   51.58%   -0.06%     
==========================================
  Files         205      205              
  Lines       17052    17052              
==========================================
- Hits         8807     8797      -10     
- Misses       7352     7357       +5     
- Partials      893      898       +5
Impacted Files Coverage Δ
pkg/stream/stream.go 46.66% <0%> (-13.34%) ⬇️
pkg/buffer/iobuffer.go 75.31% <0%> (-2.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3152073...3b44205. Read the comment docs.

@nejisama
Copy link
Contributor

Please sign CLA

@felixonmars
Copy link
Author

I already signed, not sure why the bot didn't update here.

@nejisama
Copy link
Contributor

I already signed, not sure why the bot didn't update here.

you can close this pr, and start a new one

@felixonmars felixonmars reopened this Aug 26, 2019
@nejisama
Copy link
Contributor

I already signed, not sure why the bot didn't update here.

do not reopen this one, make a new pull request

@nejisama
Copy link
Contributor

nejisama commented Sep 3, 2019

this pr still have cla bug. close it .

@nejisama nejisama closed this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants