Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate code of setFuture(). #105

Merged
merged 2 commits into from May 10, 2018

Conversation

@stateIs0
Copy link
Contributor

commented May 10, 2018

将此处重复设置 Future 的操作删除,提高性能。

xiansheng.cao and others added 2 commits May 10, 2018
莫那·鲁道
@codecov-io

This comment has been minimized.

Copy link

commented May 10, 2018

Codecov Report

Merging #105 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
+ Coverage     63.95%   63.98%   +0.03%     
+ Complexity      602      601       -1     
============================================
  Files           265      265              
  Lines         11357    11356       -1     
  Branches       1901     1901              
============================================
+ Hits           7263     7266       +3     
+ Misses         3119     3112       -7     
- Partials        975      978       +3
Impacted Files Coverage Δ Complexity Δ
...y/sofa/rpc/transport/bolt/BoltClientTransport.java 67.3% <ø> (-0.21%) 29 <0> (ø)
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 83.65% <0%> (-2.89%) 22% <0%> (-1%)
...ava/com/alipay/sofa/rpc/config/RegistryConfig.java 35% <0%> (-1%) 0% <0%> (ø)
.../alipay/sofa/rpc/registry/local/LocalRegistry.java 57.22% <0%> (-0.61%) 25% <0%> (-1%)
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 53.91% <0%> (+0.55%) 0% <0%> (ø) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 65.15% <0%> (+4.54%) 0% <0%> (ø) ⬇️
...m/alipay/sofa/rpc/module/FaultToleranceModule.java 93.33% <0%> (+26.66%) 5% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e6a67...8712ce9. Read the comment docs.

@ujjboy
ujjboy approved these changes May 10, 2018
@khotyn

This comment has been minimized.

Copy link
Member

commented May 10, 2018

@stateIs0 Good Job!

@ujjboy ujjboy merged commit 7465553 into sofastack:master May 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ujjboy ujjboy added the bug label May 10, 2018
@ujjboy ujjboy added this to To do in v5.4.x via automation May 10, 2018
@ujjboy ujjboy added enhancement and removed bug labels May 10, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone May 10, 2018
@ujjboy ujjboy changed the title 删除了重复的 setFuture() 操作,只需要在 Cluster 层操作一次就可以了。 Delete duplicate code of setFuture(). May 10, 2018
@ujjboy ujjboy added optimization and removed enhancement labels May 10, 2018
@ujjboy ujjboy moved this from To do to Done in v5.4.x May 16, 2018
@stateIs0 stateIs0 deleted the stateIs0:del_duplicate_setFuture branch Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5.4.x
  
Done
4 participants
You can’t perform that action at this time.