Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple subscribe error #1179

Merged
merged 1 commit into from Mar 8, 2022

Conversation

ZLBer
Copy link
Contributor

@ZLBer ZLBer commented Mar 7, 2022

Bugfix:

Using method computeIfAbsent avoid creating multiple informers and some Listeners failure due to multiple subscribe.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/S labels Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1179 (006d38c) into master (1e7cd58) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1179      +/-   ##
============================================
+ Coverage     71.12%   71.19%   +0.06%     
- Complexity      825      826       +1     
============================================
  Files           407      407              
  Lines         17199    17198       -1     
  Branches       2681     2680       -1     
============================================
+ Hits          12233    12244      +11     
+ Misses         3586     3579       -7     
+ Partials       1380     1375       -5     
Impacted Files Coverage Δ
...lipay/sofa/rpc/registry/consul/ConsulRegistry.java 47.51% <100.00%> (+0.26%) ⬆️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 73.88% <0.00%> (-1.12%) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 70.68% <0.00%> (+0.26%) ⬆️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 91.06% <0.00%> (+0.74%) ⬆️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 57.89% <0.00%> (+1.75%) ⬆️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 69.59% <0.00%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d26c5...006d38c. Read the comment docs.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit aa5956e into sofastack:master Mar 8, 2022
@EvenLjj EvenLjj added this to the 5.8.4 milestone Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants