Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep maven descriptor when building. #209

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented Jun 29, 2018

Motivation:

Keep maven descriptor file pom.properties and pom.xml when building.

@ujjboy ujjboy added the optimization Code optimization label Jun 29, 2018
@ujjboy ujjboy added this to the 5.4.2 milestone Jun 29, 2018
@codecov-io
Copy link

Codecov Report

Merging #209 into 5.4 will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.4     #209      +/-   ##
============================================
- Coverage     71.27%   71.23%   -0.05%     
+ Complexity      959      958       -1     
============================================
  Files           341      341              
  Lines         14213    14213              
  Branches       2286     2286              
============================================
- Hits          10130    10124       -6     
- Misses         2891     2897       +6     
  Partials       1192     1192
Impacted Files Coverage Δ Complexity Δ
...y/sofa/rpc/bootstrap/DefaultProviderBootstrap.java 63.95% <0%> (-2.54%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 72.22% <0%> (-1.12%) 23% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ef650...90f079d. Read the comment docs.

@ujjboy ujjboy merged commit 67a9650 into sofastack:5.4 Jun 29, 2018
@ujjboy ujjboy deleted the keep_maven branch June 29, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants