Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tracer class not found exp #565

Merged
merged 2 commits into from Apr 4, 2019

Conversation

@leizhiyuan
Copy link
Contributor

commented Apr 3, 2019

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@leizhiyuan leizhiyuan added this to the 5.5.2 milestone Apr 3, 2019
@@ -345,8 +345,9 @@ public void clientReceived(SofaRequest request, SofaResponse response, Throwable
throwableShow = new SofaRpcException(RpcErrorType.SERVER_UNDECLARED_ERROR, response.getErrorMsg());
} else {
Object ret = response.getAppResponse();
if (ret instanceof Throwable) {
throwableShow = (Throwable) ret;
//for server throw exception ,but this class ca not be found in current

This comment has been minimized.

Copy link
@ujjboy

ujjboy Apr 3, 2019

Member

ca not --> cannot
in current classloader?

@leizhiyuan leizhiyuan merged commit 66b1658 into sofastack:5.5 Apr 4, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
clahub All contributors have signed the Contributor License Agreement.
Details
@leizhiyuan leizhiyuan deleted the leizhiyuan:fix_tracer_issue branch Apr 4, 2019
ujjboy added a commit that referenced this pull request Apr 10, 2019
* fix tracer class not found exp
@ujjboy ujjboy added the bug label May 22, 2019
treenewtreenew added a commit to treenewtreenew/sofa-rpc that referenced this pull request Oct 7, 2019
* fix tracer class not found exp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.